Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move collections editor out of Variable Explorer into widgets #12725

Closed
goanpeca opened this issue May 13, 2020 · 3 comments · Fixed by #12726
Closed

Move collections editor out of Variable Explorer into widgets #12725

goanpeca opened this issue May 13, 2020 · 3 comments · Fixed by #12726

Comments

@goanpeca
Copy link
Member

The IPython Console, Console and (potentially) other Plugins make (might) use of the collections editor to display env variables and other information.

Since the new API work is decoupling all the moving parts and there will be a precedence in plugin order of loading, this should move out of the variable explorer, as discussed with @ccordoba12

@jitseniesen
Copy link
Member

The IPython Console, Console and (potentially) other Plugins make (might) use of the collections editor to display env variables and other information.

The same goes for the text editor, which is used by the Profiler, Code Analysis and several external plugins.

@goanpeca
Copy link
Member Author

goanpeca commented May 13, 2020

The same goes for the text editor, which is used by the Profiler, Code Analysis and several external plugins.

Indeed. Thanks for the input!

However, probably all those plugins will depend on the editor to work, so that is a different story.

@goanpeca
Copy link
Member Author

goanpeca commented May 13, 2020

Plugins will now have optional and required requirements

So it will go something like

internal console
coreui (name to be defined)
ipython console
lsp
editor

The rest...

But since the console was being loaded first, having it depend on the variable explorer did not make much sense. However having all the other plugins depend on the editor does make more sense.

@ccordoba12 ccordoba12 added this to Release in v5.0alpha1 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0alpha1
Release
Development

Successfully merging a pull request may close this issue.

2 participants