Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QDarkstyle subrepo #20392

Closed
ccordoba12 opened this issue Jan 18, 2023 · 1 comment
Closed

Remove QDarkstyle subrepo #20392

ccordoba12 opened this issue Jan 18, 2023 · 1 comment
Assignees
@mrclary
Labels
type:Task
Milestone
v5.4.3

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Jan 18, 2023 •
edited
Loading

  • The upstream Qdarkstyle repo doesn't use LF line-endings, so we're unable to keep hosting a subrepo for it here after PR PR: Enforce LF line endings in Spyder code #18691. In other words, there are some conflicts when trying to update the subrepo due to that and we can't handle them here.
  • I don't think it's important for us to have a subrepo for QDarkstyle anymore. I thought that project will have more development after its 3.0 release (potentially including a lot of breaking changes to our interface), but that hasn't been the case. So, it's safe to remove it.
@ccordoba12 ccordoba12 added this to the v5.4.3 milestone Jan 18, 2023
@ccordoba12
Copy link
Member Author

ccordoba12 commented Jan 18, 2023 •
edited
Loading

@mrclary, could you take care of this one? I think it'll impact our installers one way or another, so it'd be better if you handle it.

@mrclary mrclary self-assigned this Jan 18, 2023
@mrclary mrclary mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrclary mrclary

Labels
type:Task
Projects
None yet
Milestone
v5.4.3
Development

No branches or pull requests
2 participants
@ccordoba12 @mrclary