Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current EOL status is displayed incorrectly after changing it #2392

Closed
ssoloff opened this issue May 2, 2015 · 2 comments
Closed

Current EOL status is displayed incorrectly after changing it #2392

ssoloff opened this issue May 2, 2015 · 2 comments

Comments

@ssoloff
Copy link
Contributor

ssoloff commented May 2, 2015

Description

After changing the EOL for a file, both the associated menu item and status bar panel do not correctly display the new EOL.

  • What steps will reproduce the problem?
    1. Open a file with Windows EOL. (This bug can be reproduced with any initial EOL. I simply chose one to make the reproduction steps concrete.)
    2. Select Source > Convert end-of-line characters > Line feed (UNIX).
  • What is the expected output?
    • The Source > Convert end-of-line characters > Carriage return and line feed (Windows) menu item is unchecked.
    • The Source > Convert end-of-line characters > Line feed (UNIX) menu item is checked.
    • The End-of-lines status bar panel displays LF.
  • What do you see instead?
    • The Source > Convert end-of-line characters > Carriage return and line feed (Windows) menu item is checked.
    • The Source > Convert end-of-line characters > Line feed (UNIX) menu item is checked.
    • The End-of-lines status bar panel displays CRLF.
  • Please provide any additional information below
    • The menu item continues to display the incorrect EOL until Spyder is restarted.
    • The status bar panel is updated with the correct EOL if you open any menu (e.g. File) and then close it.
    • The status bar panel is updated with the correct EOL if Spyder loses focus and subsequently regains it (e.g. ALT+TAB to a different window and then ALT+TAB back).
    • The status bar panel is updated with the correct EOL after saving the file.

Version and main components

  • Spyder Version: 2.3.4
  • Python Version: 3.4.3
  • Qt Version : 4.8.6, PyQt4 (API v2) 4.11.3 on Windows

Optional dependencies

pyflakes >=0.6.0: 0.8.1 (OK)
pep8 >=0.6 : 1.6.2 (OK)
IPython >=1.0 : 3.0.0 (OK)
zmq >=2.1.11 : 14.5.0 (OK)
pygments >=1.6 : 2.0.2 (OK)
pandas >=0.13.1 : 0.16.0 (OK)
sphinx >=0.6.6 : None (NOK)
rope >=0.9.2 : 0.9.4-1 (OK)
jedi >=0.8.1 : None (NOK)
matplotlib >=1.0: 1.4.3 (OK)
sympy >=0.7.3 : 0.7.6 (OK)
pylint >=0.25 : 1.4.3 (OK)

@ssoloff
Copy link
Contributor Author

ssoloff commented May 2, 2015

Created PR #2393 for this issue. Please see my comments in part (3) of the commit message regarding the quality of that portion of this fix. I'm sure there's a better way to do it.

@ccordoba12
Copy link
Member

Thanks for the bug report and the pull request. I hope to review it soon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants