Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a unique instance of the file switcher #4575

Closed
dalthviz opened this issue Jun 8, 2017 · 5 comments
Closed

Make a unique instance of the file switcher #4575

dalthviz opened this issue Jun 8, 2017 · 5 comments

Comments

@dalthviz
Copy link
Member

dalthviz commented Jun 8, 2017

The idea here is to make a generic file switcher attached to the main window that could display the files of the plugins, for example the Editor and the Notebook (and others if needed).

The file switcher should display a list with the possible files grouped by plugin like:

Editor
file1
file2

Notebook
notebook1
notebook2

The plugins should give the file switcher a list with the current files that are managing.

@ccordoba12
@goanpeca , what do you think?

@dalthviz dalthviz added this to the v3.2 milestone Jun 8, 2017
@dalthviz dalthviz self-assigned this Jun 8, 2017
@ccordoba12
Copy link
Member

+1 from me too. Please start to work on it.

@rlaverde
Copy link
Member

rlaverde commented Jun 9, 2017

This is somehow related to #4368, maybe you could address it too.

@dalthviz
Copy link
Member Author

A pre-preview:

gfileswitcher

@ccordoba12
Copy link
Member

@dalthviz, it looks great! What's missing for a PR?

@dalthviz
Copy link
Member Author

@ccordoba12 I need to clean the code a little bit (code style, comments, variable names, etc.), but It should be ready soon 👍, also probably write the prerequisites and steps to attach a plugin to the file switcher, and do some testing to see if this changes work for the whole functionality of the file switcher (search by file and by symbol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants