Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator on plots plugin acts more like a button than a resize area #9747

Closed
goanpeca opened this issue Jul 4, 2019 · 9 comments · Fixed by #9720
Closed

Separator on plots plugin acts more like a button than a resize area #9747

goanpeca opened this issue Jul 4, 2019 · 9 comments · Fixed by #9720

Comments

@goanpeca
Copy link
Member

goanpeca commented Jul 4, 2019

The separator has the appearance of allowing the user to change the width gradually, but currently the behavior is more of something being toggled (a button instead of a draggable area)

plots

@jnsebgosselin
Copy link
Member

Is a button like in adobe reader what you have in mind? Or we could also simply add a button to the plugin toolbar that allow to hide/show the thumbnails scrollbar? The later option would be easier to do.

acrobat_sidebar_button

@goanpeca
Copy link
Member Author

goanpeca commented Jul 4, 2019

Is a button like in adobe reader what you have in mind?

If that is the road we are taking then yes, (it would be a tool button with a expanding vertical policy)

The later option would be easier to do.

I guess, but the UX of having the button right there feels nicer? Besides ease of implementation any particular preferences @jnsebgosselin ?

The other option is that the dragging actually reduces gradually the size of the thumbnails (from a minimum value, to a maximum value)

@jnsebgosselin
Copy link
Member

The other option is that the dragging actually reduces gradually the size of the thumbnails (from a minimum value, to a maximum value)

Is it something that would be worth implementing? I think this wouldn't be too complicated to do and could be done as part of PR #9720.

@goanpeca
Copy link
Member Author

goanpeca commented Jul 4, 2019

I do not have a particular favorite to be honest, it is the UX/UI that bothers me. Either way is fine by me as long as the UX/UI is consistent.

  • If a toggle button, hide show the thumbnails.
  • If a size grip, allow for gradual change of thumbnail

If either seems like too much for nothing then I guess the button on the toolbar is fine 🤷‍♂

Thoughts @ccordoba12 ?

@ccordoba12
Copy link
Member

The other option is that the dragging actually reduces gradually the size of the thumbnails (from a minimum value, to a maximum value)

I also prefer this option instead of the current behavior. Thankfully is not too complicated to implement (according to @jnsebgosselin), so it'd be nice to have it as part of PR #9720.

@jnsebgosselin
Copy link
Member

The other option is that the dragging actually reduces gradually the size of the thumbnails (from a minimum value, to a maximum value)

I also prefer this option instead of the current behavior. Thankfully is not too complicated to implement (according to @jnsebgosselin), so it'd be nice to have it as part of PR #9720.

Ok good, I'll work on it 👍

@goanpeca
Copy link
Member Author

goanpeca commented Jul 5, 2019

Thanks @jnsebgosselin !

@goanpeca
Copy link
Member Author

goanpeca commented Jul 5, 2019

Question @jnsebgosselin then in this case we would still need the toggle button in the toolbar? so that users can completely hide it? The resize should probably have a minimum value (otherwise it would be "lost"?

@jnsebgosselin
Copy link
Member

Question @jnsebgosselin then in this case we would still need the toggle button in the toolbar? so that users can completely hide it? The resize should probably have a minimum value (otherwise it would be "lost"?

We can set a minimum value on the resize and if the user continue to drag after hitting the minimum, the scrollbar would collapse.

That being said, I think that also adding a collapse button in the toolbar is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment