Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close search bar after searching #408

Closed
Dylancyclone opened this issue Mar 28, 2023 · 6 comments · Fixed by #487
Closed

Close search bar after searching #408

Dylancyclone opened this issue Mar 28, 2023 · 6 comments · Fixed by #487
Labels
enhancement New feature or request

Comments

@Dylancyclone
Copy link

First of all, thank you for making this project, I really love the idea!

Something I noticed while using the application is that after opening the search bar and opening one of the results, the search bar is minimized but not closed, forcing you to alt-tab twice to get back to the original window.

Code_gdVb3UhUQ4.mp4

I immediately noticed this when working with multiple windows, where I wanted to pull something up with Spyglass as a quick reference and get back to the original task, and I keep alt-tabbing back into the search box even though I expect it to have closed once the search finished.
(I also noticed that the search bar isn't always auto focused, but that's probably something else).
Is this a design choice or a setting I've missed?

@a5huynh
Copy link
Collaborator

a5huynh commented Mar 29, 2023

Hey @Dylancyclone, this is currently a design choice but I can see how that can be confusing. Would you prefer to have it disappear immediately after selecting a result?

@a5huynh a5huynh added the enhancement New feature or request label Mar 29, 2023
@Dylancyclone
Copy link
Author

Dylancyclone commented Mar 29, 2023

Personally yes, especially when working with multiple windows so that the alt-tab menu doesn't become cluttered.

I've never done any Rust development before, but I can take a stab at in a few days if you'd like
Sorry, life has decided to get in the way and I don't think I'll have the chance

@brooksvb
Copy link

I agree with this. I find it undesirable to have the window minimize itself automatically, and would prefer it closes entirely. The opening time of the search window is fast enough that I don't see why I would want it to remain.

Additionally, this has an undesired interaction with my AwesomeWM based desktop environment. If I open Spyglass on one workspace, it will minimize and remain on that workspace. If I then try to re-open it in a different workspace, it will open on the old one instead, when I would want it to appear on whatever workspace is active when I try to open it.

I could fix this by scripting my AwesomeWM configuration to always move the window to the active workspace, but that's a little cumbersome to do when it seems like a transient, always-available search dialog should just behave like that naturally.

Has anyone complained that the window opens too slow from a "cold start"?

Love the project and thanks for your efforts.

@brooksvb
Copy link

brooksvb commented Apr 1, 2023

Just came across this in the Tauri docs:
https://tauri.app/v1/guides/features/system-tray#preventing-the-app-from-closing
Particularly the section of "Keep the Frontend Running in the Background"

I searched for references to "CloseRequested" in the app, and didn't find any, so I am guessing you are not using this method? Perhaps this method will allow the window to "close", but still be ready to bring up and load quickly instead of "cold-starting" every time.

@a5huynh
Copy link
Collaborator

a5huynh commented Apr 2, 2023

Thanks for looking into that @brooksvb, I'll see if we can merge this into the upcoming release

@Real-Gecko
Copy link

I'm OK with search bar staying, but I don't like that search results area cleared after I select a match:

output2.mp4

So, maybe it's better to make the behavior configurable?
And also not to clear the results when user prefers for window to stay :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants