Implemented various XmlReader APIs, notably ReadElementString and dep…

…endencies, plus Skip
sq · Apr 12, 2012 · df72ef2 · df72ef2
1 parent ddd0a8e
commit df72ef2
Show file tree

Hide file tree

Showing 6 changed files with 349 additions and 13 deletions.
diff --git a/Libraries/JSIL.Bootstrap.js b/Libraries/JSIL.Bootstrap.js
@@ -3034,6 +3034,19 @@ JSIL.ImplementExternals("System.Activator", function ($) {
       return JSIL.CreateInstanceOfType(type, args);
     }
   );
+
+  $.Method({Static:true , Public:true }, "CreateInstance", 
+    (new JSIL.MethodSignature($.Object, [
+          $asms[5].TypeRef("System.Type"), $asms[5].TypeRef("System.Reflection.BindingFlags"), 
+          $asms[5].TypeRef("System.Reflection.Binder"), $jsilcore.TypeRef("System.Array", [$.Object]), 
+          $asms[5].TypeRef("System.Globalization.CultureInfo")
+        ], [])), 
+    function CreateInstance (type, bindingAttr, binder, args, culture) {
+      // FIXME
+      return JSIL.CreateInstanceOfType(type, args);
+    }
+  );
+
 });
 
 JSIL.ImplementExternals("System.Diagnostics.Stopwatch", function ($) {

diff --git a/Libraries/JSIL.Core.js b/Libraries/JSIL.Core.js
@@ -4085,23 +4085,26 @@ JSIL.CreateInstanceOfType = function (type, constructorName, constructorArgument
   } else {
     constructor = publicInterface.prototype["_ctor"];
 
-    if ((typeof (constructor) !== "function") || (constructor.__IsPlaceholder__)) {
-      JSIL.Host.warning("Type '" + type.__FullName__ + "' has no default constructor!");
-      return instance;
-    }
-
     constructorArguments = constructorName;
     constructorName = null;
   }
 
-  if (!JSIL.IsArray(constructorArguments))
-    constructorArguments = [];
-
   if (type.__IsNativeType__) {
     // Native types need to be constructed differently.
     return constructor.apply(constructor, constructorArguments);
   }
 
+  if (!JSIL.IsArray(constructorArguments))
+    constructorArguments = [];
+
+  if (type.__IsStruct__ && (constructorArguments.length === 0))
+    return instance;
+
+  if ((typeof (constructor) !== "function") || (constructor.__IsPlaceholder__)) {
+    JSIL.Host.warning("Type '" + type.__FullName__ + "' has no default constructor!");
+    return instance;
+  }
+
   if (typeof (constructor) !== "function") {
     if (typeof(constructorName) === "string")
       throw new Error("Type '" + String(type) + "' has no constructor named '" + constructorName + "'.");