Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-1 Substitution Day Doesn't Work for Christmas 2022 #576

Closed
mattsmac opened this issue Jan 17, 2023 · 2 comments
Closed

-1 Substitution Day Doesn't Work for Christmas 2022 #576

mattsmac opened this issue Jan 17, 2023 · 2 comments
Labels
area-ManageDates ManageDates module issues bug Something isn't working
Milestone

Comments

@mattsmac
Copy link

Describe the problem

When adding Christmas Eve to the US holidays for 2022 and setting both Christmas Eve and Christmas Day to -1 substitution type, I expected Christmas Day Observed to fall on 12/26/2022 and Christmas Eve Observed to fall on 12/23/2022 since Christmas Eve fell on a Saturday and Christmas Day fell on a Sunday. Instead Christmas day is still 12/25 (a Sunday), although Christmas Eve was moved appropriately.

Bravo version

1.0.1 (1.0.8381.30060)

Tabular model

Power BI Desktop, import mode

Power BI

Power BI Desktop version October 2022

Steps to reproduce the behavior

In the HolidaysDefinition table, add/update these two lines.

{ "US", 12, 24, 0, 0, 0, "Christmas Eve", -1, 100, 0, 0 },
{ "US", 12, 25, 0, 0, 0, "Christmas Day", -1, 100, 0, 0 },

Create a table in PowerBI and show all dates and holiday names. Filter to not include blank holiday names, and limit to just 2022 dates.

Additional context

No response

Screenshots

image

Anything else ?

No response

@mattsmac mattsmac added bug Something isn't working untriaged A new issue requiring triage labels Jan 17, 2023
@mattsmac
Copy link
Author

FYI I just updated to the latest build of PowerBI Desktop (Version: 2.112.1161.0 64-bit (December 2022)) and the issue still happens.

@albertospelta albertospelta added this to the v1.0.8 milestone Apr 11, 2024
@albertospelta albertospelta added area-ManageDates ManageDates module issues and removed untriaged A new issue requiring triage labels Apr 11, 2024
@albertospelta
Copy link
Collaborator

We have identified the issue, and the fix is available in version 1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ManageDates ManageDates module issues bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants