Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Dates > Interval | Inactive Relationships does not include Active Relationships #686

Closed
tabertantrum opened this issue Jun 20, 2023 · 3 comments · Fixed by #688
Closed
Assignees
Labels
area-ManageDates ManageDates module issues bug Something isn't working
Milestone

Comments

@tabertantrum
Copy link

Describe the problem

When selecting Inactive Relationships in Automatic Scan for Date Interval, the expression generated only includes Inactive Relationship columns.

Bravo Documentation indicates Inactive Relationships should include both Active and Inactive Relationships:

Active Relationships only considers the date columns that are part of an active relationship.
Inactive Relationships only considers the date columns that are part of both active and inactive relationships.

Bravo version

1.0.8566.15194

Tabular model

Power BI Desktop, import mode

Power BI

Power BI Desktop version June 2023

Steps to reproduce the behavior

  1. Create a model with both Active and Inactive relationships to Date table
  2. Apply Bravo date template with "Inactive Relationships" option chosen
  3. Preview changes
  4. Review Expression for DateAutoTemplate and confirm that only columns with an Inactive Relationship to Date table are included in the VAR __FirstYear and VAR __LastYear definitions

Additional context

No response

Screenshots

No response

Anything else ?

No response

@tabertantrum tabertantrum added bug Something isn't working untriaged A new issue requiring triage labels Jun 20, 2023
@albertospelta albertospelta self-assigned this Jun 21, 2023
@albertospelta albertospelta added area-ManageDates ManageDates module issues and removed untriaged A new issue requiring triage labels Jun 21, 2023
@albertospelta albertospelta added this to the v1.0.4 milestone Jun 21, 2023
@albertospelta albertospelta linked a pull request Jun 21, 2023 that will close this issue
@albertospelta
Copy link
Collaborator

Hi @tabertantrum, thank you for reporting this issue! It's a bug and I have just pushed the fix.

This fix will be available in next release but, if you are interested in testing the preview build, you can get it by changing the update channel from Stable to Dev in the Bravo options panel and then follow the download link.

@tabertantrum
Copy link
Author

Thanks @albertospelta! I have downloaded the Dev version and confirmed all inactive and active relationship fields are properly included when selecting Inactive Relationships.

@albertospelta
Copy link
Collaborator

Fixed in version 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ManageDates ManageDates module issues bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants