Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated code in CompoundMessage.__repr__ #97

Open
Yancey1989 opened this issue Dec 26, 2019 · 2 comments
Open

Duplicated code in CompoundMessage.__repr__ #97

Yancey1989 opened this issue Dec 26, 2019 · 2 comments
Labels

Comments

@Yancey1989
Copy link
Collaborator

The if and else branch have the same code:

for r in self._messages:
if isinstance(r[0], Rows):
all_string = '\n'.join([all_string, r[0].__repr__()])
else:
all_string = '\n'.join([all_string, r[0].__repr__()])
return all_string

@AayushTyagi1
Copy link

Can I work on this issue?

@AayushTyagi1
Copy link

@Yancey1989 I have solved this issue, please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants