Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_index documentation and typing should allow a None name #1168

Closed
simark opened this issue Feb 8, 2023 · 2 comments
Closed

create_index documentation and typing should allow a None name #1168

simark opened this issue Feb 8, 2023 · 2 comments
Labels
bug Something isn't working pep 484 typing related issues PRs (with tests!) welcome

Comments

@simark
Copy link

simark commented Feb 8, 2023

According to:

def test_add_index_name_is_none(self):

... it is valid to pass None as the name to the create_index operation. However, the documentation and typing do not reflect it:

index_name: str,

@simark simark added the requires triage New issue that requires categorization label Feb 8, 2023
@CaselIT CaselIT added bug Something isn't working pep 484 typing related issues and removed requires triage New issue that requires categorization labels Feb 8, 2023
@CaselIT
Copy link
Member

CaselIT commented Feb 8, 2023

Hi,

Thanks for reporting.

@sqla-tester
Copy link
Collaborator

CaselIT has proposed a fix for this issue in the main branch:

Improve typing to accomodate sqlalchemy v2 https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pep 484 typing related issues PRs (with tests!) welcome
Projects
None yet
Development

No branches or pull requests

3 participants