Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alembic is passing an empty tuple to conn.execute() which is nonsensical #1394

Closed
zzzeek opened this issue Jan 10, 2024 · 3 comments
Closed
Labels
bug Something isn't working execution model

Comments

@zzzeek
Copy link
Member

zzzeek commented Jan 10, 2024

this should be fixed because in sqlalchemy/sqlalchemy#9647 we are going to disallow or warn for this

@zzzeek zzzeek added bug Something isn't working execution model labels Jan 10, 2024
@CaselIT
Copy link
Member

CaselIT commented Jan 10, 2024

this is here

multiparams: Sequence[dict] = (),

@CaselIT
Copy link
Member

CaselIT commented Jan 10, 2024

was added here 53b9ccc so it's effectively "since forever"

@sqla-tester
Copy link
Collaborator

Mike Bayer has proposed a fix for this issue in the main branch:

dont pass empty sequences to connection.execute() https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution model
Projects
None yet
Development

No branches or pull requests

3 participants