Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogpile.cache is not compatible with decorator<4.0.0 #160

Closed
vashirov opened this issue Aug 14, 2019 · 3 comments
Closed

dogpile.cache is not compatible with decorator<4.0.0 #160

vashirov opened this issue Aug 14, 2019 · 3 comments
Labels

Comments

@vashirov
Copy link

@vashirov vashirov commented Aug 14, 2019

decorator module has decorate function, which doesn't exist in versions <4.0.0 (see release notes https://github.com/micheles/decorator/blob/4.0.0/documentation.rst#what-s-new)

But dogpile.cache doesn't explicitly specify the version of decorator module in setup.py:

install_requires=["decorator"],

So if decorator-3.4.0 is installed on the system, it satisfies the dependency chain, but dogpile.cache is not functional with it:

    sdk = importlib.import_module('openstack')                                                                                                                                
  File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module                                                                                                
    __import__(name)                                                                                                                                                          
  File "/usr/lib/python2.7/site-packages/openstack/__init__.py", line 17, in <module>                                                                                         
    import openstack.connection                                                                                                                                               
  File "/usr/lib/python2.7/site-packages/openstack/connection.py", line 187, in <module>                                                                                      
    from openstack.cloud import openstackcloud as _cloud                                                                                                                      
  File "/usr/lib/python2.7/site-packages/openstack/cloud/openstackcloud.py", line 21, in <module>                                                                             
    import dogpile.cache                                                                                                                                                      
  File "/usr/lib/python2.7/site-packages/dogpile/cache/__init__.py", line 1, in <module>                                                                                      
    from .region import CacheRegion, register_backend, make_region  # noqa                                                                                                    
  File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 15, in <module>                                                                                       
    from decorator import decorate     
@zzzeek zzzeek added the bug label Aug 14, 2019
@zzzeek
Copy link
Member

@zzzeek zzzeek commented Aug 14, 2019

4.0.0 was July 2015 so this issue is unlikely to have wide impact

Loading

@zzzeek
Copy link
Member

@zzzeek zzzeek commented Aug 14, 2019

confirm 4.0.0 starts working

Loading

@sqla-tester
Copy link
Collaborator

@sqla-tester sqla-tester commented Aug 14, 2019

Mike Bayer has proposed a fix for this issue in the master branch:

Pin minimum decorator version at 4.0.0 https://gerrit.sqlalchemy.org/1414

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants