Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threading related deprecation warnings in Python 3.10 #203

Closed
tirkarthi opened this issue May 24, 2021 · 4 comments
Closed

Threading related deprecation warnings in Python 3.10 #203

tirkarthi opened this issue May 24, 2021 · 4 comments

Comments

@tirkarthi
Copy link
Contributor

Python 3.10 deprecates camelCase aliases in threading module.

Ref : python/cpython#25174

notifyAll -> notify_all
currentThread -> current_thread

dogpile/util/readwrite_lock.py
65:                # yes. so if a sync operation is waiting, notifyAll to wake
68:                    self.condition.notifyAll()
98:            self.current_sync_operation = threading.currentThread()
120:            if self.current_sync_operation is not threading.currentThread():
@zzzeek
Copy link
Member

zzzeek commented May 25, 2021

thanks! are these names in python 3.6? that's our bottom version right now. I would assume they are.

@zzzeek
Copy link
Member

zzzeek commented May 25, 2021

"The snake_case names have existed since Python 2.6," - wow! i had no idea.

@sqla-tester
Copy link
Collaborator

Karthikeyan Singaravelan has proposed a fix for this issue in the master branch:

Fix DeprecationWarning due to camelCase aliases in Python 3.10. https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/2840

1 similar comment
@sqla-tester
Copy link
Collaborator

Karthikeyan Singaravelan has proposed a fix for this issue in the master branch:

Fix DeprecationWarning due to camelCase aliases in Python 3.10. https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/2840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants