Adding tests to check behavioral changes introduced by decorator #145
Conversation
Test cache region behaviors when `**kw` was passed to cache_on_arguments wrapped functions (with and without). We expect for a ValueError when **kw are passed to wrapped function. Related to sqlalchemy#144 Change-Id: Ic76113f06f80d2fb05f64a8468ad8184fd361bbd
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work to try to get revision 1e971d4 of this pull request into gerrit so we can run tests and reviews and stuff
|
not sure how well dogpile CI is working here we'll see |
|
my CI hook didn't work here, I'll have to find some time to see why it's not configured for this project correctly. |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work to try to get revision 1e971d4 of this pull request into gerrit so we can run tests and reviews and stuff
|
it's your username! UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 95: ordinal not in range(128) figured it was permissions or someting....OK fixing |
|
@zzzeek oh ok lol |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work to try to get revision 1e971d4 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 1e971d4: https://gerrit.sqlalchemy.org/#/c/sqlalchemy/dogpile.cache/+/1144 |
|
mike bayer (zzzeek) wrote: I've added you to the contributors group so you can optionally push directly to this gerrit. if you push to the github PR I can also synchronize that here. |
|
Hervé Beraud (4383) wrote:
Great! Thanks |
|
mike bayer (zzzeek) wrote: Verified+1 we're not doing pep8 on dogpile yet... |
|
Hervé Beraud (4383) wrote: Code-Review+1 |
|
mike bayer (zzzeek) wrote: Verified+1 Code-Review+2 Workflow+1 |
|
Gerrit review https://gerrit.sqlalchemy.org/1144 has been merged. Congratulations! :) |
Test cache region behaviors when
**kwwas passed to cache_on_argumentswrapped functions (with and without).
We expect for a ValueError when **kw are passed to wrapped function.
Related to #144
PS:
Sorry I'll submit my patch on gerrit but it seem that I doesn't have the right to upload...