How can I contribute about typing issue and make it support both of version 1.4 and 2+? #11496
Unanswered
fResult
asked this question in
Usage Questions
Replies: 1 comment
-
Hi, For 1.4 you have the stub package https://github.com/sqlalchemy/sqlalchemy2-stubs. PR will not be accepted to type the 1.4 branch, since 1.4 is in major bug fix only mode currently. If you care about typing you should upgrade to version 2.0 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Ensure stubs packages are not installed
sqlalchemy-stubs
andsqlalchemy2-stubs
are not compatible with v2)Verify if the api is typed
Describe the typing issue
How can we make it support back to the SQLAlchemy version 1.4?
As I forked this repository and found the
or_
andand_
functions, they already have a typeBut version 1.4 isn't (my company is not ready to upgrade to v.2)
The
![image](https://private-user-images.githubusercontent.com/19329932/339731115-76849b67-64cd-4e3a-86c4-02b370158626.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwOTIwOTQsIm5iZiI6MTcyMDA5MTc5NCwicGF0aCI6Ii8xOTMyOTkzMi8zMzk3MzExMTUtNzY4NDliNjctNjRjZC00ZTNhLTg2YzQtMDJiMzcwMTU4NjI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDExMTYzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmYTE3YWMyYzk0NDFjYTc5N2EzZDI0Y2JmNmI5MmI2YTBlMmJkZDViODM1Njc1ZmNjYTAyMzg3MjJhMmNmNjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ho4F5GeEKRZ0-kfgDnnftNgv5CRiZ9XqqJi-jV8xxGc)
public_factory
function is inferred asAny
(here is the SQLAlchemy 1.4 lib code on my local)If I do something like this...
![image](https://private-user-images.githubusercontent.com/19329932/339733005-f02ba6b1-03f8-4d0b-9b34-e8dc41c93931.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwOTIwOTQsIm5iZiI6MTcyMDA5MTc5NCwicGF0aCI6Ii8xOTMyOTkzMi8zMzk3MzMwMDUtZjAyYmE2YjEtMDNmOC00ZDBiLTliMzQtZThkYzQxYzkzOTMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDExMTYzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJiNWU0MWZiNjQwZmI5NDliYWVkOWY4MGI1NWQzOGE3OTU0MDQwZTc0NWRlYjYzYWI3MDRmZGRiZWNiNTkzNDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4to9rdiP6nuCv3H02QCyaXy3lLbo_91blJkGqvWTqAE)
... it's work
To Reproduce
Error
Versions
Additional context
No response
Beta Was this translation helpful? Give feedback.
All reactions