Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No public access to query._execution_options #4464

Closed
daniel-- opened this issue Jan 24, 2019 · 3 comments
Closed

No public access to query._execution_options #4464

daniel-- opened this issue Jan 24, 2019 · 3 comments
Labels
bug Something isn't working orm
Milestone

Comments

@daniel--
Copy link
Contributor

This recipe uses the private variable query._execution_options. There should be a getter for this variable to avoid private variable access.

Fix incoming.

@zzzeek
Copy link
Member

zzzeek commented Jan 24, 2019

heya.

we could use this for Connection and Engine also if you've thought of a good name for the accessor (get_execution_options() ? im not a huge fan of getters, prefer @property)

@zzzeek zzzeek added orm bug Something isn't working labels Jan 24, 2019
@zzzeek zzzeek added this to the 1.2.x milestone Jan 24, 2019
@daniel--
Copy link
Contributor Author

Sure, I can add one for Connection and Engine also, I went with get_execution_options() but I agree on preferring @property the problem is execution_options is already a function on Query

@zzzeek
Copy link
Member

zzzeek commented Feb 3, 2019

we got the issue number wrong, this was fixed with https://gerrit.sqlalchemy.org/#/c/sqlalchemy/sqlalchemy/+/1112/, needs to be updated

@zzzeek zzzeek modified the milestones: 1.2.x, 1.3 Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working orm
Projects
None yet
Development

No branches or pull requests

2 participants