Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to remove/change the emojis of the output #1246

Closed
Arwiim opened this issue Aug 5, 2021 · 8 comments · Fixed by #1249
Closed

Add the option to remove/change the emojis of the output #1246

Arwiim opened this issue Aug 5, 2021 · 8 comments · Fixed by #1249
Assignees
Labels
enhancement New feature or request

Comments

@Arwiim
Copy link

Arwiim commented Aug 5, 2021

It would be nice if we can have a option to change/modify/remove the emojis of the output.

image

@Arwiim Arwiim added the enhancement New feature or request label Aug 5, 2021
@barrywhart
Copy link
Member

@Arwiim: One possible implementation would be to extend this existing option to also suppress the emoji output:

  -n, --nocolor                   No color - if this is set then the output
                                  will be without ANSI color codes.

This existing option and your request seem similar -- in both cases, the intent is to get plain text output. What do you think?

Tagging @nolanbconaway, who was involved in the Slack conversation about this (in the #help channel).

@Arwiim
Copy link
Author

Arwiim commented Aug 5, 2021

Well it doesn't, the only think that -n do its removes the colors, but not the emojis
image
@nolanbconaway

@nolanbconaway
Copy link
Member

Yep! i never set it up to be disabled on -n but ought to have!

@barrywhart
Copy link
Member

@Arwiim: Right, I was discussing the design for a possible fix. This is definitely not the current behavior.

To clarify, I'm proposing we extend the behavior of an existing command-line option rather than adding a new one.

@Arwiim
Copy link
Author

Arwiim commented Aug 6, 2021

Thanks for the support! look forward to a new version with this corrected

@nolanbconaway nolanbconaway self-assigned this Aug 6, 2021
@barrywhart
Copy link
Member

Hey @nolanbconaway: I started work on this before I saw you'd assigned it to yourself. 😿 I'll go ahead and create a PR -- hope that's okay.

@barrywhart barrywhart self-assigned this Aug 6, 2021
@nolanbconaway
Copy link
Member

Lol ofc

@barrywhart
Copy link
Member

Cool cool. I'm sorry about that! I made a list of a few issues to look at as the notifications were coming in. I also looked briefly at #1248, which looks slightly scary (templating + rules + busted fix). If I can get some advice from Alan, I might look into that one. 😬😰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants