T-SQL: Explicit aliasing of columns broken when using =

[fdw]

Search before asking

• I searched the issues and found no similar issues.

What Happened

I fear #2727 broke something.
Take this example:

select key = value
from table

With L012 set to explicit aliases, the result is invalid SQL:

select as key = value
from table

Instead, I would expect

select value as key
from table

or (preferably)

select key = value
from table

Expected Behaviour

See above: Not broken code, either using as or = but not both ;)

Observed Behaviour

sqlfluff currently adds an as, but also keeps the aliasing with =.

How to reproduce

See above: Use that snippet and call sqlfluff fix on it.

Dialect

T-SQL

Version

Current master

Configuration

[sqlfluff]
dialect = tsql

[sqlfluff:rules:L011] # Aliasing
aliasing = implicit

[sqlfluff:rules:L012] # Aliasing
aliasing = explicit

Are you willing to work on and submit a PR to address the issue?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[tunetheweb]

Yes I really think L012 is currently incompatible with this usage of aliasing. So think it needs to be turned off.

But concerning it corrupts SQL if people don't realise that. Would be good to update L012 to ignore this aliasing before 0.11.0 to avoid that issue.

[tunetheweb]

I get linting errors with your examples. key, value and table are not valid sql.

[tunetheweb]

Managed to fix it in #2750

[fdw]

Awesome, thank you!