Setting is_fix_compatible on JJ01 results in runaway fix.

[alanmcruickshank]

Search before asking

• I searched the issues and found no similar issues.

What Happened

I set is_fix_compatible = True in #4473 and it resulted in spiralling errors. This means at the moment, the rule is not documented as fixable in the docs.

Expected Behaviour

I expected it to work nicely.

Observed Behaviour

Looking at the logs I see the line:

DEBUG    sqlfluff.linter:base.py:1335 Matched fix for JJ01 against segment: <LintFix: replace placeholder@[L:  1, P: 15] src-edt:[SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None)), SourceFix(edit='{%+ if true -%}', source_slice=slice(14, 27, None), templated_slice=slice(14, 14, None))]> -> <TemplateSegment: ([L:  1, P: 15]) ''>

Which appears to indicate that the rule doesn't cope well with looping in the fix phase. I think the combination of source fixes and rules which loop is not a good one.

How to reproduce

Set is_fix_compatible = True in JJ01 and the yaml tests for JJ01 will fail (or at least two of them will).

Dialect

ansi

Version

main as at 9c2ce9e

Configuration

default

Are you willing to work on and submit a PR to address the issue?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct