Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/MariaDB dialect #5856

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feature/MariaDB dialect #5856

wants to merge 12 commits into from
+16,902 −2

Conversation

Xemptuous
Copy link

Brief summary of the change made

fixes #5840 by adding new MariaDB dialect based off mysql.

This PR does a few things:

  • Adds core functionality for MariaDB
  • Adds partitions/subpartitions and partition_option/subpartition_option to table DDL for MySQL
  • Adds REGEXP into LikeGrammar for MySQL

Are there any other side effects of this change that we should be aware of?

Potentially more complex tests would be required to ensure the added sections for partitions do not affect other code in larger scripts.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@WittierDinosaur
Copy link
Contributor

is this meant to be in draft?

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17755      0   100%

227 files skipped due to complete coverage.

@Xemptuous
Copy link
Author

is this meant to be in draft?

Yea I set it as a draft so I can go through other areas that MariaDB's dialect potentially differs from MySQL in a critical way, while still providing visibility.

@WittierDinosaur
Copy link
Contributor

The PR is already pretty massive - feel free to add to this incrementally later. The first drop doesn't need to be a full implementation

@Xemptuous Xemptuous marked this pull request as ready for review May 19, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MariaDB into existing MySQL, or new dialect for CREATE/DROP [OR REPLACE] ?
3 participants
@Xemptuous @WittierDinosaur @alanmcruickshank