Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement on segment comparison #5303

Merged
merged 2 commits into from Oct 10, 2023
Merged

Conversation

alanmcruickshank
Copy link
Member

Very very small change, but has a sizable performance impact on segment comparisons, which is important for LT02 performance. This halved the bottleneck speed of the linting step in my large test file. There is almost certainly more work to be done here, but thought I should get this merged first.

@coveralls
Copy link

coveralls commented Oct 10, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 110bc81 on ac/reflow_perf2 into 6683bb4 on main.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   16675      0   100%

219 files skipped due to complete coverage.

Copy link
Member

@pwildenhain pwildenhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 8ebe8c5 Oct 10, 2023
29 checks passed
@alanmcruickshank alanmcruickshank deleted the ac/reflow_perf2 branch October 10, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants