Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join support for delete statements #182

Closed
1 of 5 tasks
ceastwood opened this issue Dec 31, 2018 · 6 comments
Closed
1 of 5 tasks

join support for delete statements #182

ceastwood opened this issue Dec 31, 2018 · 6 comments

Comments

@ceastwood
Copy link
Contributor

ceastwood commented Dec 31, 2018

If the database engine supports a delete + join syntax then compile the query, if not, throw an exception.

  • SqlServer
  • MySql
  • PostgreSQL
  • Oracle (delete from where exists ? )
  • Other compilers or throw an exception
@ceastwood
Copy link
Contributor Author

Succeeds Issue #16

@ahmad-moussawi
Copy link
Contributor

For MySql we can use this approach https://stackoverflow.com/a/4192849/1104402

@ceastwood
Copy link
Contributor Author

@ahmad-moussawi Yes sir, the syntax is pretty much the same as that for SqlServer. I will be testing it against MySql here before committing that one up.

@ceastwood ceastwood self-assigned this Jan 17, 2019
@ahmad-moussawi ahmad-moussawi added this to the version-2.0 milestone Apr 3, 2019
@ahmad-moussawi ahmad-moussawi changed the title Add delete with join support Add edit/delete with join support Aug 18, 2020
@sarvasana
Copy link

This still being worked on?
Can we get some insight on what needs to be done?

I see the SqlServer checkbox is checked.
Does that mean it is already available or is in waiting in some PR where other compilers also need to be updated?

@ahmad-moussawi ahmad-moussawi changed the title Add edit/delete with join support join support for update/delete statements Feb 10, 2022
@Dave-Coll
Copy link

is there any progress with the Delete with joins
branch from feb? #558

@ahmad-moussawi ahmad-moussawi changed the title join support for update/delete statements join support for delete statements Sep 27, 2022
@ahmad-moussawi
Copy link
Contributor

merged in #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants