Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let .Limit() accept other types of numeric values #298

Closed
KRperm opened this issue Sep 13, 2019 · 3 comments
Closed

Let .Limit() accept other types of numeric values #298

KRperm opened this issue Sep 13, 2019 · 3 comments

Comments

@KRperm
Copy link

KRperm commented Sep 13, 2019

Trying to pass long value to .Limit(), but, sadly, it accept only int. It would be nice if I can pass different types of numeric to this function.

@ahmad-moussawi
Copy link
Contributor

the maximum value of the int datatype in csharp is: Int.MaxValue which is (2 ^ 32)/2 - 1 == 2,147,483,647
which is sufficient in most cases, I don't see the real need of using long here.
let me know your feedback.

@KRperm
Copy link
Author

KRperm commented Oct 24, 2019

@ahmad-moussawi I agree that integer is enought in most cases. Limiting query to more than couple of billions rows is quite rare. But I think that sqlkata shouldn't restrict user from doing anything if there is no constraints in sql engine itself.

@ahmad-moussawi
Copy link
Contributor

Since there is no real need for this now, I will close it, we can reopen if circumstances change later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants