Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemVer? #322

Closed
Sharparam opened this issue Nov 27, 2019 · 1 comment
Closed

SemVer? #322

Sharparam opened this issue Nov 27, 2019 · 1 comment

Comments

@Sharparam
Copy link

Between versions 1.1.0 and 1.1.7 there was a breaking change introduced in SqlResult.

In 1.1.0, NamedBindings was a property (get-only):

https://github.com/sqlkata/querybuilder/blob/v1.1.0/QueryBuilder/SqlResult.cs#L25-L38

In 1.1.7, it's a public field:

https://github.com/sqlkata/querybuilder/blob/v1.1.7/QueryBuilder/SqlResult.cs#L14

This is a breaking change and should've bumped the version of SqlKata to 2.0.0. It caused some minor headaches with MissingMethodException being thrown since we had a library using 1.1.0 and an app pulling in 1.1.7, according to SemVer that should be fine but due to the above breaking change it was not.

Is this project using SemVer, or does every version change have the possibility of being a breaking change? Given that the version number looks like SemVer I just assumed it was.

@ahmad-moussawi
Copy link
Contributor

@Sharparam Yes you are right the project should be bumped to 2.0.0, I am working on a set of features/enhancements that should be pushed together soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants