Nested having doesn't work

[SonicGD]

Hello. I found a problem in building query with nested having conditions. For example:

new Query().From("Foo").Select("Id")
                .Having(q => q.Having("bla", ">", 1).OrHaving("bla", ">", 2));

compiles to

SELECT "Id" FROM "Foo" HAVING

The problem is in CompileNestedCondition method cause it check for where component:

protected virtual string CompileNestedCondition<Q>(SqlResult ctx, NestedCondition<Q> x) where Q : BaseQuery<Q>
        {
            if (!x.Query.HasComponent("where", EngineCode))
            {
                return null;
            }

            var clauses = x.Query.GetComponents<AbstractCondition>("where", EngineCode);

            var sql = CompileConditions(ctx, clauses);

            return x.IsNot ? $"NOT ({sql})" : $"({sql})";
        }

If i change it to check current condition type, eg:

protected override string CompileNestedCondition<Q>(SqlResult ctx, NestedCondition<Q> x)
        {
            if (!x.Query.HasComponent(x.Component, EngineCode))
            {
                return null;
            }

            var clauses = x.Query.GetComponents<AbstractCondition>(x.Component, EngineCode);

            var sql = CompileConditions(ctx, clauses);

            return x.IsNot ? $"NOT ({sql})" : $"({sql})";
        }

sql generates correctly:

SELECT "Id" FROM "Foo" HAVING ("bla" > 1 OR "bla" > 2)

I can send PR if this is right way to fix this.

[ahmad-moussawi]

@SonicGD it was intentionally kept to use the Where methods, since they are more flexible and supports many overloads. maybe this should be clear in the documentation.

[ahmad-moussawi]

Documentation updated, thanks for your feedback