JOIN on Query

[yankyhgoflow]

I was wondering wether there is a way to JOIN on a Query which just defines a FROM (no SELECTs etc.).

i.e.

Here is the sample SQL I am aiming to get

SELECT
  *
FROM
  "Sales"
  INNER JOIN "Items" ON ("Sales"."Item" = "Items"."Item");

However, my code is equivalent to

var query = new Query("Sales")
    .Join(new Query("Items"), join => join.On("Sales.Item", "Items.Item"));

which results in the following SQL

SELECT
  *
FROM
  "Sales"
  INNER JOIN (
    SELECT
      *
    FROM
      "Items"
  ) ON ("Sales"."Item" = "Items"."Item");

my code considers all tables as Querys which only works for the "Sales" table (as that is the initial Query), passing a Query containing only a table name results in the Join JOINing on a subquery of the table passed...

[ahmad-moussawi]

You can simply pass the table name as string,

var query = new Query("Sales")
    .Join("Items", j => j.On("Sales.Item", "Items.Item"));

Or even simpler without using the join lambda

var query = new Query("Sales")
    .Join("Items", "Sales.Item", "Items.Item");

since the join condition is simple columns equality condition.

Here is a live example https://sqlkata.com/playground?code=var%20query%20%3D%20new%20Query(%22Sales%22)%0A%20%20%20%20.Join(%22Items%22%2C%20j%20%3D%3E%20j.On(%22Sales.Item%22%2C%20%22Items.Item%22))%3B

[yankyhgoflow]

Thanks for the response.

In reality I should have started my previous post with a big thanks to you, SqlKata is really a great tool and I really appreciate the work you did and that you open sourced it!

To better phrase my question, I am using SqlKata within my project and I am wrapping my objects (whether EF models etc.) in there respective types, hence I made all my "tables" create a Query which works in the case of a single table query and it works in a JOIN query for the table on the LHS.

This is not really an issue as It might 100% be that I need to rethink the design of my little project, but I was more wondering whether there is a way in SqlKata to do it.

Once again thank you for this great tool!

[yankyhgoflow]

Reopening this issue as a PR was created to help me solve my issue.