Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements required to build and/or extend and/or modify Compilers #537

Open
mindcrash opened this issue Nov 10, 2021 · 2 comments

Comments

@mindcrash
Copy link

mindcrash commented Nov 10, 2021

While working around some issues within the Postgres compiler (like not supporting some operations required to query arrays and JSON) I discovered some issues which can be worked around right now to a certain degree but are really annoying.

  1. Some methods which could be required for modifications are marked internal or private, making them inaccessible from the outside (while you might need them). At least make sure these methods are marked protected.
  2. The parameter placeholder is coded hard in at several places, making it impossible to make the compiler work when overriding it when copying all other code using it and changing it manually.

If you are unable to clean this up yourself I am happy to prep and submit a PR once I have some free time to do so.

@generik0
Copy link

Why not clean it and make a PR?
That is what I would do :-)

@ahmad-moussawi
Copy link
Contributor

@mindcrash could you please provide a list of the methods that you need to change, maybe we can discuss this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants