Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Light Model LCT015 #112

Open
harleyjester opened this issue Aug 23, 2019 · 4 comments
Open

Add missing Light Model LCT015 #112

harleyjester opened this issue Aug 23, 2019 · 4 comments

Comments

@harleyjester
Copy link

Add missing Light Model LCT015

id: LCT015
manufacturer: Philips
name: Hue bulb A19
type: Extended Color Light
colorGamut: C

@sqmk
Copy link
Owner

sqmk commented Sep 3, 2019

Mind creating a PR with the new class?

@harleyjester
Copy link
Author

I don't know if a private repository (PR) would solve my problem.

I'm using HueMagic (https://github.com/Foddy/node-red-contrib-huemagic) which use HueJay (https://github.com/sqmk/huejay) and without the correct Model and colorGamut the calculation of the color is not correct.

@sqmk
Copy link
Owner

sqmk commented Sep 4, 2019

I’m asking for a pull request (PR) that contains the new model class with the information that is missing. You write / test the new model class locally, and then submit a pull request to the Huejay project with the new class/file you created to be included in this project going forward.

If you are not sure how to do this, I can see about creating the missing model in a near future patch release.

@harleyjester
Copy link
Author

I have testet it local for a few days and all is fine and works as expected.
So i have created a pull request from a fork, because i have no write access, with the new model class file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants