Add signoff option #336
Add signoff option #336
Conversation
|
This is great! Thanks for doing this! Will run the CI and do some manual tests and merge today or sometime this week. |
|
I've released this in v8.4.0. Please try it out and lmk if it works as expected. |
|
@sqren Thanks for releasing this so quickly! I'm trying to test this out in our repo. I'd like to use your GitHub Action to do automatic backports based on labels, but I don't think the latest version of the action uses the new version of the CLI. Do you need to cut a release for the action as well? is there some workaround I can employ to control the version of Thanks! |
|
@sqren I managed to workaround this by directly using the CLI instead of the GitHub action.
I do however think its worth either auto-upgrading and releasing the action with the latest CLI version, or allow for some escape hatching.
Thanks anyway! |
|
Thanks for the heads up. Will bump the version in the GitHub action asap and set up some automation around dependency updates |
There's currently somewhat of a mess with the backport workflow, which doesn't actually work. The action we use is [tibdex/backport@v1](https://github.com/tibdex/backport), which I mistakenly thought was internally using the [backport](https://github.com/sqren/backport) tool i've been testing this out with. The correct action to use is actually [sqren/backport-github-action](https://github.com/sqren/backport-github-action). However, the action doesn't currently use the correct version of `backport` that contains the [fix](sorenlouv/backport#336) we need for DCO to pass. I asked the author to cut a new release, but he hasn't responded yet. I then realized the action is not really necessary, since most of the logic is implemented in the `backport` tool (finally a well moduled action). So this PR configures the workflow to use the `backport` tool as a normal `run` step, via projen. Signed-off-by: Eli Polonsky <epolon@amazon.com>
There's currently somewhat of a mess with the backport workflow, which doesn't actually work. The action we use is [tibdex/backport@v1](https://github.com/tibdex/backport), which I mistakenly thought was internally using the [backport](https://github.com/sqren/backport) tool i've been testing this out with. The correct action to use is actually [sqren/backport-github-action](https://github.com/sqren/backport-github-action). However, the action doesn't currently use the correct version of `backport` that contains the [fix](sorenlouv/backport#336) we need for DCO to pass. I asked the author to cut a new release, but he hasn't responded yet. I then realized the action is not really necessary, since most of the logic is implemented in the `backport` tool (finally a well moduled action). So this PR configures the workflow to use the `backport` tool as a normal `run` step, via projen. Signed-off-by: Eli Polonsky <epolon@amazon.com> (cherry picked from commit 8c57943) Signed-off-by: Eli Polonsky <epolon@amazon.com>
There's currently somewhat of a mess with the backport workflow, which doesn't actually work. The action we use is [tibdex/backport@v1](https://github.com/tibdex/backport), which I mistakenly thought was internally using the [backport](https://github.com/sqren/backport) tool i've been testing this out with. The correct action to use is actually [sqren/backport-github-action](https://github.com/sqren/backport-github-action). However, the action doesn't currently use the correct version of `backport` that contains the [fix](sorenlouv/backport#336) we need for DCO to pass. I asked the author to cut a new release, but he hasn't responded yet. I then realized the action is not really necessary, since most of the logic is implemented in the `backport` tool (finally a well moduled action). So this PR configures the workflow to use the `backport` tool as a normal `run` step, via projen. Signed-off-by: Eli Polonsky <epolon@amazon.com> (cherry picked from commit 8c57943) Signed-off-by: Eli Polonsky <epolon@amazon.com>
|
@iliapolo I updated the dependencies for backport-github-action. It follows the same versioning as the underlying backport tool so you can update to 8.4.0 to get the |
|
Thanks @sqren - I think I'll stick to directly using the CLI though, at least until the action is automatically upgraded. I love that basically all of the functionality is in the CLI - so the action is not strictly necessary :) |
|
Btw I tested the singoff option and it works as expected |
|
Perfect, thanks for the feedback. I'll look into automatically updating the github action when the cli tool is updated. |
Apologies for jumping the gun here but since this is a fairly simple addition, I went ahead and created a PR. Hope this makes it in :)
Fixes #335