Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested components #20

Closed
pombadev opened this issue Aug 4, 2019 · 6 comments
Closed

Allow nested components #20

pombadev opened this issue Aug 4, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@pombadev
Copy link

pombadev commented Aug 4, 2019

It'd be nice to have something like:

--- My dashboard ----------------
| Component:1     | Component:2 |
|                               |
| Component:3                   |
---------------------------------
@vcavallo
Copy link

vcavallo commented Aug 4, 2019

it seems like it’s just the parent container name “My Dashboard” you’re after, right? otherwise you could have three separate components and arrange them as you have in the diagram.

@pombadev
Copy link
Author

pombadev commented Aug 4, 2019

Yeah pretty much.

@sqshq
Copy link
Owner

sqshq commented Aug 4, 2019

Hey @pjmp,
Is it purely for visualization (logical separation of area with a single title "My dashboard"), or you expect something more, like resize and move of the whole group?

@pombadev
Copy link
Author

pombadev commented Aug 5, 2019

In my use case, i was thinking of just having a bordered box with title not expecting it to be moved, however others might have different use cases tho.

@sqshq
Copy link
Owner

sqshq commented Aug 5, 2019

In this case I would suggest to not comlicate current layout with nesting support for now, since logical separation can be done with the empty textbox:

textboxes:
  - title: My dashboard
    position: [[14, 9], [47, 23]]
    sample: echo "" # JUST ECHO EMPTY STRING HERE
runcharts:
  - title: Search engine response time
    position: [[15, 19], [45, 12]]
    items:
      - label: GOOGLE
        color: 178
        sample: curl -o /dev/null -s -w '%{time_total}'  https://www.google.com
      - label: YAHOO
        sample: curl -o /dev/null -s -w '%{time_total}'  https://search.yahoo.com
sparklines:
  - title: CPU usage
    position: [[15, 10], [22, 8]]
    rate-ms: 200
    scale: 0
    sample: ps -A -o %cpu | awk '{s+=$1} END {print s}'
  - title: Free memory pages
    position: [[37, 10], [23, 8]]
    rate-ms: 200
    scale: 0
    sample: memory_pressure | grep 'Pages free' | awk '{print $3}'

Screen Shot 2019-08-05 at 7 25 17 PM

@sqshq sqshq added the enhancement New feature or request label Aug 6, 2019
@sqshq
Copy link
Owner

sqshq commented Aug 18, 2019

Closing due to inactivity. Result can be achieved with existing functionality

@sqshq sqshq closed this as completed Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants