Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Support Theme Attributes For tsquare_dayTextColor (fixes #509) #510

Merged
merged 2 commits into from Mar 8, 2022

Conversation

quentin41500
Copy link
Contributor

@quentin41500 quentin41500 commented Jan 14, 2022

Work done

Implement support for theme attributes used in selectors for app:tsquare_dayTextColor.

    app:tsquare_dayTextColor="@color/custom_calendar_text_selector"

with custom_calendar_text_selector.xml

<selector xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto">
    <item android:color="?textSelected" android:state_selected="true" />
    <item android:color="?textSelected" android:state_pressed="true" />
    <item android:color="?textDisabled" app:tsquare_state_selectable="true" />
    <item android:color="?textDefault" />
</selector>

Fixes #509

image

I did not provide an example with selector and custom attributes, but happy to do if necessary, like on this branch.

@edenman
Copy link
Collaborator

edenman commented Jan 14, 2022

thanks for the PR! first one in quite a while, I'm not sure why CI isn't running anymore. gonna try to figure that out before merging

@JakeWharton
Copy link
Member

Travis is banned at Square. You'll have to set up GitHub Actions.

@quentin41500
Copy link
Contributor Author

I didn't mean to push my example to this PR, also it might be nice to have. Let me know if you'd like to keep it or if I should clean up this PR to just the fix.

@edenman
Copy link
Collaborator

edenman commented Jan 14, 2022

Keep it. Examples are good

@quentin41500
Copy link
Contributor Author

I fixed the PR so at least, we are still relying on original colors from the example:
image

The example could now showcase light vs dark mode if we wanted to in the future.

@edenman
Copy link
Collaborator

edenman commented Mar 7, 2022

ok sorry for the delay here, it turned out to be a huge pain in the ass to get github actions working. can you rebase your branch please?

@quentin41500
Copy link
Contributor Author

ok sorry for the delay here, it turned out to be a huge pain in the ass to get github actions working. can you rebase your branch please?

Done!

@edenman edenman merged commit c6c67ad into square:master Mar 8, 2022
@edenman
Copy link
Collaborator

edenman commented Mar 8, 2022

Thanks again! I'll figure out how to roll a release for this later today or tomorrow

@edenman
Copy link
Collaborator

edenman commented Apr 6, 2022

Ok this is finally released in 1.7.11, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support attributes for color selector "tsquare_dayTextColor"
3 participants