Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with CocoaPods 1.10.beta.1 #68

Closed
paulb777 opened this issue Jul 18, 2020 · 2 comments · Fixed by #69
Closed

Incompatible with CocoaPods 1.10.beta.1 #68

paulb777 opened this issue Jul 18, 2020 · 2 comments · Fixed by #69

Comments

@paulb777
Copy link
Contributor

cocoapods-generate requires CocoaPods >= 1.5.0

Detailed log in https://github.com/firebase/firebase-ios-sdk/runs/885053344
@paulb777
Copy link
Contributor Author

paulb777 commented Jul 18, 2020 •
edited
Loading

https://metaredux.com/posts/2018/10/28/a-better-way-to-compare-versions-in-ruby.html describes a fix to lib/cocoapods_plugin.rb, but I'm not sure how to test in development.

@dnkoutso dnkoutso mentioned this issue Jul 18, 2020
Merged
@paulb777 paulb777 mentioned this issue Jul 18, 2020
Closed
@chris-hatton
Copy link

chris-hatton commented Oct 24, 2020 •
edited
Loading

Closed but not released? FYI the lack of a release for this fix is now impacting major use cases including Kotlin/iOS, because there was a critical Xcode 12 compatibility fix in Cocoapods 1.10.0.

Confirmed that my use case is fixed by building & installing latest gem from master.

@chris-hatton chris-hatton mentioned this issue Oct 26, 2020
Closed
@paulb777 paulb777 mentioned this issue Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version comparison to work with 1.10.0.beta.1 square/cocoapods-generate
2 participants
@paulb777 @chris-hatton