-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMD + RequireJS support #114
Comments
+1. I'm trying to get this working myself on a CrossFilter / DC / D3 stack using Twitter Flight and RequireJS. I don't know enough yet about AMD or I'd attempt to submit a patch myself. |
I successfully used RequireJS's shim config:
Hope this helps while we wait for this! |
+1 |
@reedspool |
@lord-xeon I'm sorry that's happening. I am not familiar with dojo, but perhaps their version of require.js is older than the shim? I don't know what version shims came around, but I am sure they were not always part of the spec. Are you able to use other, sure-fire shims? Underscore.js is commonly shim'd like this, for example. |
Yes, other shims work, such as d3. dojo uses their own custom version of require.js which makes it just about impossible to use any "AMD ready" plugin I would like (moment.js, Pnotify, etc.) |
@reedspool Thanks very much, your solution works for me. |
Would it be possible to add AMD loader support (for us poor dojo developers)?
Something similar to:
https://github.com/dc-js/dc.js/pull/590/files
The text was updated successfully, but these errors were encountered: