Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.callback.wrappedCallback crashes with java.lang.NullPointerException due to R8 obfuscation of androidx.appcompat.view.WindowCallbackWrapper #23

Closed
andriykryzhko opened this issue Jun 1, 2021 · 2 comments

Comments

@andriykryzhko
Copy link

andriykryzhko commented Jun 1, 2021

com.squareup.curtains:curtains:1.2.1
androidx.appcompat:appcompat:1.3.0
R8 mapping.txt:
androidx.appcompat.view.WindowCallbackWrapper -> impl.g1:
android.view.Window$Callback mWrapped -> c

retraced stack trace:
java.lang.NullPointerException
at curtains.internal.WindowCallbackWrapper$Companion.getJetpackWrapped(WindowCallbackWrapper.kt:112)
at curtains.internal.WindowCallbackWrapper$Companion.unwrap(WindowCallbackWrapper.kt:147)
at curtains.WindowsKt.getWrappedCallback(Windows.kt:247)

@pyricau
Copy link
Member

pyricau commented Jun 4, 2021

ah, interesting. I guess we can not crash if that class is missing, but other than that I can't think of another way to handle this.

@pyricau
Copy link
Member

pyricau commented Apr 16, 2022

Fixed by #33

@pyricau pyricau closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@pyricau @andriykryzhko and others