Add a Config.extension(block) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helios175
requested review from
patrickyin,
rjrjr and
zach-klippenstein
as code owners
zach-klippenstein
approved these changes
Apr 20, 2021
| */ | ||
| inline fun <reified E : ExtensionSpec<I>> extension(block: () -> E): E { | ||
| return extensionSpecs | ||
| .firstOrNull { it is E } as E? |
There was a problem hiding this comment.
Nit: .filterInstance<E>().firstOrNull()
| * @hide | ||
| */ | ||
| fun extension(spec: ExtensionSpec<I>) { | ||
| extensionSpecs.add(spec) | ||
| } | ||
|
|
||
| /** | ||
| * General method which is called from Extension code. DON'T USE DIRECTLY. |
There was a problem hiding this comment.
Who is the "DON'T USE DIRECTLY" speaking to? Who shouldn't use it, and who should? Somebody must be intended to use it, or it wouldn't need to exist.
There was a problem hiding this comment.
Gotcha. It's for extensions code (edges, sticky headers). Not for using directly from UI code.
There was a problem hiding this comment.
Thanks for updating the comment! LG now
Allows for extension code to optionally add an extension if not present. This might be needed in some cases where a feature (like a DSL that help define row types) need to access a common-shared object associated to the recycler.
helios175
force-pushed
the
helios175/accessextensions
branch
from
038016a
to
5886c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for extension code to optionally add an extension
if not present. This might be needed in some cases
where a feature (like a DSL that help define row types)
need to access a common-shared object associated to the
recycler.