Notify changes synchronously if possible #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to use the
mainScope.launch { calculateNotifications ; then update }
path if the updates are synchronous (for instance, when only extra item is updated, or when going from empty to not-empty).This PR changes:
Update.generateDataChangesLambdas
is notsuspend
anymore. It won't just produce a list of notifications for the UI thread, but anUpdateWork
comprising async work and notifications.Recycler.update
will receive that and decide to do the sync path (no async work) or the coroutine path (async work).onReady
and assign theadapter
that is encapsulated inapplyNotifications
and called from both places.currentUpdate
is not changed, and callonCancelled
if it changed (some other call toupdate
invalidated us).