Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callSuspending() should’t force a suspend #826

Closed
swankjesse opened this issue Dec 23, 2022 · 0 comments · Fixed by #844
Closed

callSuspending() should’t force a suspend #826

swankjesse opened this issue Dec 23, 2022 · 0 comments · Fixed by #844

Comments

@swankjesse
Copy link
Contributor

Right now InboundService always does a launch() and the caller always resumes asynchronously, even if there’s no blocking in the body of the service.

We should attempt to return synchronously when that’s possible.

On the API we’d change callSuspending to return either an encoded CancelCallback or the synchronous result.
This was referenced Jan 10, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don’t force a suspend cashapp/zipline
1 participant
@swankjesse