Update to Duktape 2.2.1. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Jul 16, 2018
| extern duk_bool_t android__date_parse_string(duk_context* ctx, const char* str); | ||
| #define DUK_USE_DATE_GET_LOCAL_TZOFFSET android__get_local_tzoffset | ||
| #define DUK_USE_DATE_PARSE_STRING android__date_parse_string | ||
| /** End Duktape-Android. */ |
There was a problem hiding this comment.
This is unfortunate. Can we file an issue or something to allow easier external customization? Or is there info as to why that isn't allowed easily?
There was a problem hiding this comment.
Agreed. I spent a bit of time trying to avoid this, but didn't want to hold the rest of the PR any longer. I got to this point by looking at the example here. I'll see if I can't find a better way (or request one) in a follow up.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108