Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSystemService() call does not delegate to Services inside FlowContextWrapper #231

Closed
Zhuinden opened this issue Feb 15, 2017 · 1 comment

Comments

@Zhuinden
Copy link

Zhuinden commented Feb 15, 2017

The FlowContextWrapper receives the services that is bound to the key, but getSystemService() does not try to call getService() using name parameter, therefore the services are not exposed through the context.

Services is received but not used: https://github.com/square/flow/blob/master/flow/src/main/java/flow/FlowContextWrapper.java#L32

@Zhuinden
Copy link
Author

return wrapper.services.getService(serviceName);

oh it's not exposed through Context, only through Flow.getService(name).

How odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant