Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation issues to fix for beta #251

Open
rjrjr opened this issue Apr 19, 2017 · 1 comment
Open

Documentation issues to fix for beta #251

rjrjr opened this issue Apr 19, 2017 · 1 comment
Labels
Milestone

Comments

@rjrjr
Copy link
Collaborator

rjrjr commented Apr 19, 2017

Services is basically undocumented, and has this stale bit in it.

  /**
   * Sets up any services associated with the key, and make them accessible via the context.
   * Typically this means returning a new context that wraps the given one.
   */
  public abstract void bindServices(@NonNull Services.Binder services);

I'll add other doc issues to this ticket as I notice them.

@rjrjr rjrjr added this to the 1.0 beta milestone Apr 19, 2017
@rjrjr rjrjr added the bug label Apr 19, 2017
@dcow
Copy link
Contributor

dcow commented Apr 19, 2017

It would be good to know the memory management expectations around when bind/teardown are called. From what I could gather, services are bound when a key is added to the stack and torn down when the key leaves the stack (not when it's no longer the top). If services are meant to replace flow-path and be the integration point for a scoping solution like mortar, then some sort of documentation around the behavior is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants