Upload single sha256sums file for dist build #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyczkowski
reviewed
Oct 18, 2019
| @@ -61,4 +59,5 @@ dist: | |||
| @$(MAKE) -f Makefile ghostunnel.man | |||
| @mv ghostunnel.man "${CURRENT_DIR}/dist/ghostunnel-${VERSION}.man" | |||
| @$(MAKE) -f "${MKFILE_PATH}" -j1 build | |||
| @cd "${CURRENT_DIR}/dist/" && sha256sum ghostunnel-* > sha256sums.txt | |||
There was a problem hiding this comment.
would this actually append instead of override?
There was a problem hiding this comment.
It should overwrite, since I used > (as opposed to >>).
There was a problem hiding this comment.
Also, to be clear, we want to overwrite here. At this point in the script all binaries have been created and we sha256sum them all at once.
There was a problem hiding this comment.
Good context, yes this is exactly what I was wondering here.
mbyczkowski
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better than having lots of small files for each binary, makes the release a bit cleaner. I did this for the v1.5.1 release to patch the recent Go CVE, this PR is the cherry-pick on master.