Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POM name for display friendliness #2455

Merged
merged 2 commits into from May 22, 2023

Conversation

justintuchek
Copy link
Contributor

Not sure if this is intentional or not - so please feel free to close

Consumers of https://github.com/cashapp/licensee will be displaying this as the artifact name in OSS attribution pages

    {
        "groupId": "com.squareup.leakcanary",
        "artifactId": "plumber-android-core",
        "version": "2.9.1",
        "name": "Use Plumber Android to fix known leaks in the Android Framework and other Google Android libraries.",
        "spdxLicenses": [
            {
                "identifier": "Apache-2.0",
                "name": "Apache License 2.0",
                "url": "https://www.apache.org/licenses/LICENSE-2.0"
            }
        ],
        "scm": {
            "url": "https://github.com/square/leakcanary/"
        }
    }

Trying for consistency to match leakcanary-android-core

Shoutout to @hopewm for actually noticing this in our application 馃檱

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2022

CLA assistant check
All committers have signed the CLA.

@pyricau
Copy link
Member

pyricau commented Dec 27, 2022

Thanks @justintuchek I don't know why I wrote a description instead of name.

Would you mine signing the CLA through CLAassistant?

@pyricau
Copy link
Member

pyricau commented May 17, 2023

Ping on signing CLAassistant :)

@pyricau pyricau merged commit c35c7e1 into square:main May 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants