Loader: Add favicon link for /static/favicon.ico (#811)

* Fix link for `@misk/` resources
cashapp · Mar 2, 2019 · 4aec797 · 4aec797
1 parent 5fe327e
commit 4aec797
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/misk/src/main/kotlin/misk/web/metadata/AdminDashboardModule.kt b/misk/src/main/kotlin/misk/web/metadata/AdminDashboardModule.kt
@@ -47,7 +47,7 @@ class AdminDashboardModule(val environment: Environment) : KAbstractModule() {
         slug = "@misk",
         web_proxy_url = "http://localhost:9100/",
         url_path_prefix = "/@misk/",
-        resourcePath = "classpath:/web/@misk/"
+        resourcePath = "classpath:/web/_tab/loader/@misk/"
     ))
 
     // Config

diff --git a/misk/web/tabs/loader/src/index.html b/misk/web/tabs/loader/src/index.html
@@ -7,6 +7,7 @@
       content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0"
     />
     <meta http-equiv="X-UA-Compatible" content="ie=edge" />
+    <link rel="shortcut icon" type="image/x-icon" href="/static/favicon.ico" />
   </head>
 
   <body>

diff --git a/misk/web/tabs/loader/tsconfig.json b/misk/web/tabs/loader/tsconfig.json
@@ -29,15 +29,9 @@
     "sourceMap": true,
     "stripInternal": true,
     "target": "es5",
-    "typeRoots": [
-      "../node_modules/@types"
-    ],
-    "types": [
-      "node"
-    ]
+    "typeRoots": ["../node_modules/@types"],
+    "types": ["node"]
   },
-  "include": [
-    "src/**/*"
-  ]
+  "include": ["src/**/*"]
 }
-// Generated by @misk/cli.
+// Generated by @misk/cli.
diff --git a/misk/web/tabs/loader/tslint.json b/misk/web/tabs/loader/tslint.json
@@ -1,4 +1,4 @@
 {
   "extends": "@misk/tslint"
 }
-// Generated by @misk/cli.
+// Generated by @misk/cli.