Add unit test for ConfigAdminAction

misk/src/test/kotlin/misk/web/actions/ConfigAdminActionTest.kt

@@ -0,0 +1,73 @@
+package misk.web.actions
+
+import misk.config.Config
+import misk.config.ConfigAdminAction
+import misk.environment.Environment
+import misk.testing.MiskTest
+import misk.testing.MiskTestModule
+import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
+
+@MiskTest(startService = true)
+class ConfigAdminActionTest {
+  @MiskTestModule
+  val module = TestAdminDashboardActionModule()
+
+  val testConfig = TestConfig(
+      IncludedConfig("foo"),
+      OverriddenConfig("bar"),
+      RedactedConfig("pass1", "phrase2"))
+
+  lateinit var configAdminAction: ConfigAdminAction
+
+  @BeforeEach fun beforeEach() {
+    configAdminAction = ConfigAdminAction(
+        "admin_dashboard_app",
+        Environment.TESTING,
+        testConfig)
+  }
+
+  @Test fun passesAlongEffectiveConfig() {
+    val response = configAdminAction.getAll()
+    assertThat(response.resources).containsKey("Effective Config")
+
+    val effectiveConfig = response.resources.get("Effective Config")
+
+    assertThat(effectiveConfig).contains("foo", "bar")
+  }
+
+  @Test fun passesAlongFullUnderlyingConfigResources() {
+    val response = configAdminAction.getAll()
+    assertThat(response.resources).containsKey("classpath:/admin_dashboard_app-common.yaml")
+    assertThat(response.resources).containsKey("classpath:/admin_dashboard_app-testing.yaml")
+
+    val commonConfig = response.resources.get("classpath:/admin_dashboard_app-common.yaml")
+    val testingConfig = response.resources.get("classpath:/admin_dashboard_app-testing.yaml")
+
+    // ignored included because full file is passed along
+    assertThat(commonConfig).contains("common", "ignored")
+    assertThat(testingConfig).contains("testing")
+  }
+
+  @Test fun redactsConfig() {
+    val response = configAdminAction.getAll()
+    assertThat(response.resources).containsKey("classpath:/admin_dashboard_app-common.yaml")
+    assertThat(response.resources).containsKey("Effective Config")
+
+    val commonConfig = response.resources.get("classpath:/admin_dashboard_app-common.yaml")
+    val effectiveConfig = response.resources.get("Effective Config")
+
+    assertThat(commonConfig).doesNotContain("phrase123")
+    assertThat(effectiveConfig).doesNotContain("pass1", "phrase2")
+  }
+
+  data class TestConfig(
+    val includedConfig: IncludedConfig,
+    val overriddenConfig: OverriddenConfig,
+    val redactedConfig: RedactedConfig) : Config
+
+  data class IncludedConfig(val key: String): Config
+  data class OverriddenConfig(val key: String): Config
+  data class RedactedConfig(val password: String, val passphrase: String): Config
+}

misk/src/test/kotlin/misk/web/actions/TestAdminDashboardActionModule.kt

@@ -17,4 +17,4 @@ class TestAdminDashboardActionModule : KAbstractModule() {
   }
 }
 
-class TestAdminDashboardConfig : Config
+class TestAdminDashboardConfig : Config

misk/src/test/resources/admin_dashboard_app-common.yaml

@@ -0,0 +1,8 @@
+included_config:
+  key: common
+
+ignored_config:
+  key: ignored
+
+redacted_config:
+  passphrase: phrase123

misk/src/test/resources/admin_dashboard_app-testing.yaml

@@ -0,0 +1,5 @@
+included_config:
+  key: testing
+
+redacted_config:
+  password: phrase123