Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceGraphBuilder #984

Merged
merged 18 commits into from May 16, 2019
Merged

ServiceGraphBuilder #984

merged 18 commits into from May 16, 2019

Commits on May 15, 2019

  1. WIP

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    1ed97ff View commit details
    Browse the repository at this point in the history

  2. WIP: start order correct 

    infinite looping on the stop order when stopping enhancements
    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    f9e2de7 View commit details
    Browse the repository at this point in the history

  3. enhanced coordinated services working!

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    4279ba2 View commit details
    Browse the repository at this point in the history

  4. started porting over old tests to CoordinatedService2

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    f372872 View commit details
    Browse the repository at this point in the history

  5. check dependency map and small code cleanup

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    12162ca View commit details
    Browse the repository at this point in the history

  6. reduce test boilerplate and stub new tests

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    b275da9 View commit details
    Browse the repository at this point in the history

  7. WIP: most tests passing 

    TODO:
 - merge cycle checks
 - ensure enhanced services shutdown completely before the dependent
   services
    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    b4ce4e5 View commit details
    Browse the repository at this point in the history

  8. WIP: most tests passing again 

    TODO: Graph with only transitive enhancements is looping infinitely for
some reason :(
TODO: Failure to detect cycle when created by combo of enhancements and
dependencies.
    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    f21ecb2 View commit details
    Browse the repository at this point in the history

  9. WIP: cycle detection broken when enhancement loop

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    5be10a6 View commit details
    Browse the repository at this point in the history

  10. all tests passing!!

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    1d3d902 View commit details
    Browse the repository at this point in the history

  11. cleaned up and documented classes

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    3f4ceaf View commit details
    Browse the repository at this point in the history

  12. formatted code and made minor updates to documentation

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    bf2d9cf View commit details
    Browse the repository at this point in the history

  13. finalized API and clarified docs

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    2b67eac View commit details
    Browse the repository at this point in the history

  14. removed stray empty class

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    45e189f View commit details
    Browse the repository at this point in the history

  15. updated docs and cleaned up implementation a bit 

    (pairing session with Jesse Wilson)
    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    f844c93 View commit details
    Browse the repository at this point in the history

  16. addressed comments from @swankjesse

    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    b6b460d View commit details
    Browse the repository at this point in the history

  17. changed SGBuilder.enhancementMap to mutableMap 

    The key-value relationship in ServiceGraphBuilder.enhancementMap has been
swapped.

Consequences of this:
 + this would've meant that each enhancement (value) would have been
   wrapped in listOf to fit the call to CS2.addEnhancements()
 + to keep the API symmetric for addEnhancements and addDependencies,
   these functions have been changed to take vararg parameters
   - I think this is nicer, but maybe it's not 🤷
    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    5b34926 View commit details
    Browse the repository at this point in the history

  18. prevented adding dependencies once graph is built 

    Added checks to `addDependencies()` and `addEnhancements()` methods to
ensure that neither the service nor the dependent services are running
when modifying the dependency graph.

Added a check to ensure that a CoordinatedService2 only wraps NEW
services.
    @keeferrourke
    keeferrourke committed May 15, 2019
    Copy the full SHA
    10e38a8 View commit details
    Browse the repository at this point in the history