Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to stop presenters #44

Closed
ghost opened this issue Mar 1, 2014 · 2 comments
Closed

Need to be able to stop presenters #44

ghost opened this issue Mar 1, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 1, 2014

Presenter#takeView performs a registration that cannot be undone. If a long lived scope needs to have some presenters that come and go, it really can't.

I think that MortarScope#register needs to return a Registration or Subscription object with a void unsubsribe() method. And I think that Presenter needs a void stop() method that makes it undo the registration it sets up in takeView.

@pyricau
Copy link
Member

pyricau commented Mar 1, 2014

Correct me if I'm wrong, but until now I think we had handled that by creating subscopes. What's changed here?

@ghost
Copy link
Author

ghost commented Mar 2, 2014

I'm in a situation where I don't have a subscope. But you have a point there, maybe I should just make one. I'll try that out and close this if it seems practical.

cc @dnkoutso

@ghost ghost closed this as completed Mar 27, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant