Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support serializing multi level/label polymorphic object #1340

Open
eneim opened this issue May 7, 2021 · 1 comment · May be fixed by #1728
Open

Support serializing multi level/label polymorphic object #1340

eneim opened this issue May 7, 2021 · 1 comment · May be fixed by #1728
Labels
enhancement

Comments

@eneim
Copy link

eneim commented May 7, 2021 •
edited

Currently, the Polymorphic adapter supports deserializing multi-level inheritance with different label well, but it could not serialize them correctly. I have a test to reproduce the issue: eneim@d491d18

By multi level/label polymorphic object, I mean a class that can be extended by multiple class that shares a label A, and some of those subclasses can be further extended and share a label B != A and they form a tree. Please take a look at the github branch for an example.

I would like to ask if it is possible to support such case?
@ZacSweers ZacSweers mentioned this issue Sep 26, 2021
Closed
@SebSegond
Copy link

Hello,

Any news on this issue ?

@eneim eneim linked a pull request Aug 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Proposal] Correctly encode/decode multi level type hierarchy with multiple labels. eneim/moshi
2 participants
@eneim @SebSegond