Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly instantiate qualifier annotations in Kotlin 1.6+ #1382

Closed
4 tasks
ZacSweers opened this issue Aug 23, 2021 · 1 comment · Fixed by #1390
Closed
4 tasks

Directly instantiate qualifier annotations in Kotlin 1.6+ #1382

ZacSweers opened this issue Aug 23, 2021 · 1 comment · Fixed by #1390
Labels
enhancement

Comments

@ZacSweers
Copy link
Collaborator

https://youtrack.jetbrains.com/issue/KT-45395 will allow for direct instantiation of annotations, which would save us the current workaround of storing them on a field and reflectively looking them up.

  • Update to Kotlin 1.6
  • Generate code that directly invoke qualifier annotations
  • Remove generated proguard rules for keeping these annotations
  • Remove requirement for qualifier annotations to support FIELD use site targets
@ZacSweers ZacSweers mentioned this issue Sep 4, 2021
Merged
@ZacSweers
Copy link
Collaborator Author

PR up here #1390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support direct annotation instantiation in code gen on Kotlin 1.6 square/moshi
1 participant
@ZacSweers