We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This caused the Go folks some grief. It doesn’t impact us as much (clients control which servers they contact), but it’s good to be careful.
https://groups.google.com/forum/m/#!topic/golang-announce/cszieYyuL9Q
The text was updated successfully, but these errors were encountered:
Seems awkward
https://github.com/1184893257/okhttp/blob/master/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HeadersTest.java#L136
@Test public void ofTrims() { Headers headers = Headers.of("\t User-Agent \n", " \r OkHttp "); assertEquals("User-Agent", headers.name(0)); assertEquals("OkHttp", headers.value(0)); }
https://github.com/1184893257/okhttp/blob/master/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HeadersTest.java#L262
@Test public void ofMapTrimsKey() { Headers headers = Headers.of(singletonMap(" User-Agent ", "OkHttp")); assertThat(headers.name(0)).isEqualTo("User-Agent"); }
Sorry, something went wrong.
@swankjesse Are you happy that we change the behaviour and tests here? Fix is simple if so, and we just publicise it in our release.
Unclear what action we should take. Note that there’s another potential attack on response headers.
No branches or pull requests
This caused the Go folks some grief. It doesn’t impact us as much (clients control which servers they contact), but it’s good to be careful.
https://groups.google.com/forum/m/#!topic/golang-announce/cszieYyuL9Q
The text was updated successfully, but these errors were encountered: